On Fri, 14 Dec 2007 23:20:30 PST, Matti Linnanvuori said: > From: Matti Linnanvuori <[email protected]> > > /dev/urandom use no uninit bytes, leak no user data > > Signed-off-by: Matti Linnanvuori <[email protected]> > > --- > > --- a/drivers/char/random.c 2007-12-15 09:09:37.895414000 +0200 > +++ b/drivers/char/random.c 2007-12-15 09:12:02.607831500 +0200 > @@ -689,7 +689,7 @@ static ssize_t extract_entropy(struct en > */ > static void xfer_secondary_pool(struct entropy_store *r, size_t nbytes) > { > - __u32 tmp[OUTPUT_POOL_WORDS]; > + static __u32 tmp[OUTPUT_POOL_WORDS]; This looks like a race waiting to happen - what lock is held so we don't have 'tmp' smashed by 2 instances on different CPUs (not a problem when each instance lives on a hopefully separate stack)?
Attachment:
pgpn1cthSeUUc.pgp
Description: PGP signature
- References:
- /dev/urandom uses uninit bytes, leaks user data
- From: Matti Linnanvuori <[email protected]>
- /dev/urandom uses uninit bytes, leaks user data
- Prev by Date: Re: [PATCH] x86_64: fix problems due to use of "outb" to port 80 on some AMD64x2 laptops, etc.
- Next by Date: Re: [PATCH 4/8] unify paravirt parts of system.h
- Previous by thread: /dev/urandom uses uninit bytes, leaks user data
- Next by thread: Re: /dev/urandom uses uninit bytes, leaks user data
- Index(es):
 |