Re: [PATCH] time: add an offline-cpu check in add_timer_on()

Miao Xie <[email protected]> writes:

> Hi everyone,
>   I think we need a check in the function add_timer_on() to avoid adding a
> timer into the timer list of an offline cpu.
>
> This patch fixes this problem in add_timer_on().

No it doesn't -- it will just crash if a caller does that. If it's a real 
problem then you either need to fix the callers or change add_timer_on()
to transparently put it onto another CPU.

I don't think it's a real problem though because CPU offlining does
a stop machine and that should take care of most such races.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] time: add an offline-cpu check in add_timer_on()
    • From: Thomas Gleixner <[email protected]>

• References:
  • [PATCH] time: add an offline-cpu check in add_timer_on()
    • From: Miao Xie <[email protected]>

• Prev by Date: Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex
• Next by Date: Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex
• Previous by thread: [PATCH] time: add an offline-cpu check in add_timer_on()
• Next by thread: Re: [PATCH] time: add an offline-cpu check in add_timer_on()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]