Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

>--- a/arch/x86/mm/fault_64.c
>+++ b/arch/x86/mm/fault_64.c
>@@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres
> 	pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK); 
> 	pgd += pgd_index(address);
> 	if (bad_address(pgd)) goto bad;
>-	printk("PGD %lx ", pgd_val(*pgd));
>+	printk("PGD %lx ", (unsigned long)pgd_val(*pgd));

Casts like this here and elsewhere look rather odd (in fact I think using
casts should really be limited to places where you either can't do it
differently or the code would become badly readable or much uglier
without them). I would therefore favor simply using the right formatting
specifier here.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/4] x86: clean up asm-x86/page*.h
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [PATCH 1/4] x86: clean up asm-x86/page*.h
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: Re: [PATCH]Avoid the overflow when calculate the proportion of bdi quota
• Next by Date: Re: [PATCH] x86: fix ref-counting bug in change_page_attr()
• Previous by thread: [PATCH 1/4] x86: clean up asm-x86/page*.h
• Next by thread: Re: [PATCH 1/4] x86: clean up asm-x86/page*.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]