Re: Print taint info in more places.

Dave Jones <[email protected]> writes:

>  #define WARN_ON(condition) ({						\
>  	int __ret_warn_on = !!(condition);				\
>  	if (unlikely(__ret_warn_on)) {					\
> -		printk("WARNING: at %s:%d %s()\n", __FILE__,		\
> -			__LINE__, __FUNCTION__);			\
> +		printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n",	\
> +			 __FILE__, __LINE__, __FUNCTION__,		\
> +			 print_tainted());				\
>  		dump_stack();						\

Have you checked how this affects code size? It might be worth it 
now to do a out of line helper.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Print taint info in more places.
    • From: Dave Jones <[email protected]>
  • Re: Print taint info in more places.
    • From: "Mauricio Mauad Menegaz Filho" <[email protected]>

• References:
  • Print taint info in more places.
    • From: Dave Jones <[email protected]>

• Prev by Date: Re: RFC: remove __read_mostly
• Next by Date: Re: Possible issue with dangling PCI BARs
• Previous by thread: Print taint info in more places.
• Next by thread: Re: Print taint info in more places.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]