Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss

[Glauber de Oliveira Costa <gcosta@redhat.com>]

Tom Spink wrote:
> On Dec 13, 2007 9:26 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> > Ingo Molnar wrote:
> > > > could we _please_ use basic tools as vmlinux size comparison and
> > > > objcompare when unifying, to make sure it's a 100% identity
> > > > conversion?
> > > case in point, the patch claims:
> > >
> > > > > No functional change is made.
> > > but vmlinux before/after size comparison shows:
> > >
> > >     text    data     bss     dec     hex filename
> > >  8802894 1224910 3526656 13554460         ced31c vmlinux.before
> > >  8803042 1224910 3526656 13554608         ced3b0 vmlinux.after
> > Well, "no functional changes" is not quite the same thing as "no object
> > code changes".
> >
> >         -hpa
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
>
> I'm by far no expert on the subject, but after a quick eyes-debug,
> have you got the size and type parameters reversed here:
>
> +       set_tssldt_descriptor(&tss, (unsigned long)addr,
>                IO_BITMAP_OFFSET + IO_BITMAP_BYTES + sizeof(unsigned long) - 1,
>                DESC_TSS);
>
> Should DESC_TSS be the parameter before that big size equation?
That's it. I made this mistake once, and fixed it. But I may have sent 
an older, and obviously wrong version of the patch. My fault.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/