Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss

Tom Spink wrote:

On Dec 13, 2007 9:26 PM, H. Peter Anvin <[email protected]> wrote:

Ingo Molnar wrote:

could we _please_ use basic tools as vmlinux size comparison and
objcompare when unifying, to make sure it's a 100% identity
conversion?

case in point, the patch claims:

No functional change is made.

but vmlinux before/after size comparison shows:

    text    data     bss     dec     hex filename
 8802894 1224910 3526656 13554460         ced31c vmlinux.before
 8803042 1224910 3526656 13554608         ced3b0 vmlinux.after

Well, "no functional changes" is not quite the same thing as "no object
code changes".

        -hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

I'm by far no expert on the subject, but after a quick eyes-debug,
have you got the size and type parameters reversed here:

+       set_tssldt_descriptor(&tss, (unsigned long)addr,
               IO_BITMAP_OFFSET + IO_BITMAP_BYTES + sizeof(unsigned long) - 1,
               DESC_TSS);

Should DESC_TSS be the parameter before that big size equation?

That's it. I made this mistake once, and fixed it. But I may have sent an older, and obviously wrong version of the patch. My fault.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: Glauber de Oliveira Costa <[email protected]>
  • Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
    • From: "Tom Spink" <[email protected]>

• Prev by Date: Re: What was the problem with quicklists and x86-64?
• Next by Date: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
• Previous by thread: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
• Next by thread: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]