Andi Kleen wrote:
+static inline void pack_tss(tss_desc *tss, unsigned long addr, + unsigned size, unsigned entry) +{ +#ifdef CONFIG_X86_64 + set_tssldt_descriptor(tss, + addr, entry, size); +#else + pack_descriptor(tss, (unsigned long)addr, + size, + 0x80 | entry, 0);It would be better if you just unified that first instead of ifdef'ing. I guess i386 could get a set_tssldt_descriptor() like wrapperaround pack_descriptor().
Good point. Thanks, Andi. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 10/19] provide tss_desc
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 11/19] change write_gdt_entry signature.
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 12/19] change write_ldt_entry signature
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 13/19] move constants to desc_defs.h
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 14/19] unify non-paravirt parts of desc.h
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 15/19] use the same data type for tls_array.
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 16/19] modify get_desc_base
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 17/19] unify paravirt pieces of descriptor handling
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 19/19] unify set_tss_desc
- From: Glauber de Oliveira Costa <[email protected]>
- Re: [PATCH 19/19] unify set_tss_desc
- From: Andi Kleen <[email protected]>
- [PATCH 10/19] provide tss_desc
- Prev by Date: Next patches for the 2.6.25 queue
- Next by Date: Re: [PATCH][KJ] 8250: remove unnecessary variable tmout from wait_for_xmitr()
- Previous by thread: Re: [PATCH 19/19] unify set_tss_desc
- Next by thread: [PATCH 0/19 -v4] desc_struct integration
- Index(es):
 |