Re: [PATCH 0/19] desc_struct integration

[Glauber de Oliveira Costa <gcosta@redhat.com>]

Ingo Molnar wrote:
> * Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
>
> > Ingo Molnar wrote:
> > > * Ingo Molnar <mingo@elte.hu> wrote:
> > >
> > > > > > Ingo, in the absense of further complaints, could you please push to 
> > > > > > the x86 tree?
> > > > > yeah, i've added them.
> > > > the patches cause a spontaneous reboot on x86 64-bit, around the time 
> > > > when bootup hits user-space. It's due to one of the 25 patches from you 
> > > > today. Config attached.
> > > likely caused by this patch:
> > >
> > >   Subject: unify non-paravirt parts of desc.h
> > >
> > > _please_ be more careful when unifying. Do check the before/after vmlinux 
> > > - the binary size at least. And watch out for compiler warnings as well:
> > >
> > >  arch/x86/kernel/process_64.c: In function 'read_32bit_tls':
> > >  arch/x86/kernel/process_64.c:454: warning: passing argument 1 of 'get_desc_base' from incompatible pointer type
>
> > I saw this warning, and this was fixed in the patch that follows. But 
> > yeah, I could have done a separate one, to avoid it. Do you have any 
> > other reason to believe this is the cause?
>
> that is bisection-unfriendly - every patch has to work.
I know, and I'm sorry. I thought it was not that bad, by being just a 
warning due to a type cast. ;-)
(famous last words, I know)

> > My box booted fine with the changes, but I'm re-verifying, and will 
> > send and update soon.
>
> please try the config i sent - does that boot fine on your box?
No, it doesn't. I'll bisect it, and send an updated series, with your 3 
concerns addressed.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/