[2.6 patch] drivers/media/Makefile: always enter video/

[Adrian Bunk <bunk@kernel.org>]

On Wed, Dec 12, 2007 at 12:46:21PM -0200, Mauro Carvalho Chehab wrote:
> Em Qua, 2007-12-12 às 08:42 -0500, Michael Krufky escreveu:
> > > ERROR: "tea5761_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5761_autodetection" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5767_autodetection" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5767_attach" [drivers/media/video/tuner.ko] undefined!
> 
> > It looks like the problem has something to do with VIDEO_TUNER=m while
> > both TUNER_TEA5761 & TUNER_TEA5767 are set to 'y'.
> > 
> > I thought that we had already seen this issue and fixed it, but I guess
> > not :-/
> > 
> > One would think that this could be fixed by making TUNER_TEA5761 &
> > TUNER_TEA5767 both depend on VIDEO_TUNER , but that would be wrong,
> > since each of those modules can be attached directly to a bridge driver
> > without tuner.ko being present at all (although this is not done in
> > practice right now, but it *is* the case with some other tuner drivers)
> 
> I don't see any issue on making both dependent on VIDEO_TUNER for
> 2.6.24, since they are currently used only by tuner core module
> (tuner.ko).
>...

If "selected code isn't included" also counts as a bug at least dabusb 
is also affected by the same bug.

What about the patch below instead that fixes the actual bug instead of 
working around it?

> Cheers,
> Mauro

cu
Adrian


<--  snip  -->


Since not all code under drivers/media/video/ depends on 
CONFIG_VIDEO_DEV we cannot only enter it depending
on CONFIG_VIDEO_DEV.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
9c315b376729908cbdde8adaea0d7bc0a47a2c36 
diff --git a/drivers/media/Makefile b/drivers/media/Makefile
index 8fa1993..8cf9135 100644
--- a/drivers/media/Makefile
+++ b/drivers/media/Makefile
@@ -3,6 +3,6 @@
 #
 
 obj-y := common/
-obj-$(CONFIG_VIDEO_DEV) += video/
+obj-y += video/
 obj-$(CONFIG_VIDEO_DEV) += radio/
 obj-$(CONFIG_DVB_CORE)  += dvb/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/