[PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

Remove the bogus netif_running() check from myri10ge_poll().

This eliminates any chance that myri10ge_poll() can trigger
an oops by calling netif_rx_complete() and returning
with work_done == budget.

Signed-off-by: Andrew Gallatin <[email protected]>

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 8def865..c90958f 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1239,7 +1239,7 @@ static int myri10ge_poll(struct napi_str
 	/* process as many rx events as NAPI will allow */
 	work_done = myri10ge_clean_rx_done(mgp, budget);
 
-	if (work_done < budget || !netif_running(netdev)) {
+	if (work_done < budget) {
 		netif_rx_complete(netdev, napi);
 		put_be32(htonl(3), mgp->irq_claim);
 	}

---

• Follow-Ups:
  • Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
    • From: David Miller <[email protected]>

• Prev by Date: Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]
• Next by Date: Re: A peek at the future of storage
• Previous by thread: [HP6XX/FIX/PATCH] - Fix bad default keymap in HP Jornada 6xx keyboard driver
• Next by thread: Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]