Patch looks good, it seems a merge conflict of
commit 19bc5133dae9562e8824ef101464061f9854c1d8
was resolved the wrong way.
@Mauro:
Any objections against a later path that changes the exports to the
general "immediately after the function" convention?
It would have avoided at least two such bugs in this file alone since
2.6.23...
cu
Adrian
On Wed, Dec 12, 2007 at 12:20:31AM -0500, Shane wrote:
> In 2.6.24-rc5+, I hit this problem with videobuf_read_start
> not being exported. Patch attached, only compile tested.
>
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/linux/compile.h
> CC [M] drivers/media/video/videobuf-core.o
> Building modules, stage 2.
> Kernel: arch/x86/boot/bzImage is ready (#1)
> MODPOST 202 modules
> ERROR: "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Shane
> diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
> index de2f56b..44fa76b 100644
> --- a/drivers/media/video/videobuf-core.c
> +++ b/drivers/media/video/videobuf-core.c
> @@ -1058,6 +1058,7 @@ EXPORT_SYMBOL_GPL(videobuf_dqbuf);
> EXPORT_SYMBOL_GPL(videobuf_streamon);
> EXPORT_SYMBOL_GPL(videobuf_streamoff);
>
> +EXPORT_SYMBOL_GPL(videobuf_read_start);
> EXPORT_SYMBOL_GPL(videobuf_read_stop);
> EXPORT_SYMBOL_GPL(videobuf_stop);
> EXPORT_SYMBOL_GPL(videobuf_read_stream);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
