Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU

Trond Myklebust wrote:
> On Sun, 2007-12-09 at 19:52 +0100, Berkhan, Enrik (GE Infra, Oil & Gas)
> wrote:
>> - generic_file_mmap returns -ENOSYS for NOMMU systems; replicate this  
>> behaviour 
> 
> Why do that after going through the process of revalidating the inode
> etc.? Just replace nfs_file_mmap() with a function returning ENOSYS in
> the case of CONFIG_MMU.
> 
> Better still, in the case of CONFIG_MMU, instead of having an
> nfs_file_mmap(), just replace the .mmap field in nfs_file_operations
> with a call to generic_file_mmap().

I just tried to make it work without really knowing what I do :)

I have mailed another patch implementing your second suggestion (the system
still boots with nfsroot).

Enrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
    • From: Trond Myklebust <[email protected]>

• References:
  • [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
    • From: "Berkhan, Enrik (GE Infra, Oil & Gas)" <[email protected]>
  • Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
    • From: Trond Myklebust <[email protected]>

• Prev by Date: [PATCH 1/1] replace 2.6.24-rc1 nfs_file_mmap by generic_file_mmap for nommu systems
• Next by Date: Re: [PATCH] block: use jiffies conversion functions in scsi_ioctl.c
• Previous by thread: Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
• Next by thread: Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]