Re: [PATCH] exec: allow > 2GB executables to run on 64-bit systems

Dave Anderson <[email protected]> writes:

> When a executable that is greater than 2GB in size is attempted on a 64-bit
> system on a file system that calls, or uses generic_file_open() as its
> open handler, it fails with an EOVERFLOW erro.  This patch adds a call
> to force_o_largefile() call in open_exec(), as done in sys_open() and
> sys_openat().

Wouldn't it be better to just always pass O_LARGEFILE unconditionally
there? e.g. in theory a 2.5GB executable should work on i386 and binfmt_*
shouldn't have any problems with a large file.
That would simplify your patch.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] exec: allow > 2GB executables to run on 64-bit systems
  - From: Dave Anderson <[email protected]>

References:
- [PATCH] exec: allow > 2GB executables to run on 64-bit systems
  - From: Dave Anderson <[email protected]>

Prev by Date: [PATCH 27/28] AFS: Implement shared-writable mmap [try #2]
Next by Date: [PATCH 28/28] FS-Cache: Make kAFS use FS-Cache [try #2]
Previous by thread: [PATCH] exec: allow > 2GB executables to run on 64-bit systems
Next by thread: Re: [PATCH] exec: allow > 2GB executables to run on 64-bit systems
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]