On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote: > In doing a massive kobject cleanup of the kernel tree, I ran across the > iseries_veth.c driver. > > It looks like the driver is creating a number of subdirectories under > the driver sysfs directory. This is odd and probably wrong. You want > these virtual connections to show up in the main sysfs device tree, not > under the driver directory. > > I'll be glad to totally guess and try to move it around in the sysfs > tree, but odds are I'll get it all wrong as I can't really test this > out :) > > Any hints on what this driver is trying to do in this sysfs directories? I wrote the code, I think, but it's been a while - I'll have a look at it tomorrow. Why is it "odd and probably wrong" to create subdirectories under the driver in sysfs? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: drivers/net/iseries_veth.c dubious sysfs usage
- From: Greg KH <[email protected]>
- Re: drivers/net/iseries_veth.c dubious sysfs usage
- References:
- drivers/net/iseries_veth.c dubious sysfs usage
- From: Greg KH <[email protected]>
- drivers/net/iseries_veth.c dubious sysfs usage
- Prev by Date: Re: Kernel Development & Objective-C
- Next by Date: Re: [PATCH] Updates to nfsroot documentation (take 2)
- Previous by thread: drivers/net/iseries_veth.c dubious sysfs usage
- Next by thread: Re: drivers/net/iseries_veth.c dubious sysfs usage
- Index(es):
 |