On Tue, 2007-12-04 at 22:32 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[email protected]> wrote:
>
> > I'm not sure if the definition of asmlinkage and prevent_tail_call can
> > be omitted as well and let the linux/linkage.h version get picked up
> > instead.
>
> no, we cannot remove them - asmlinkage is needed for the syscall entry
> (and other entry code) to work, the and the prevent_tail_call works
> around a compiler bug. (which might or might not be fixed in latest gcc
> - but we generally dont remove workarounds unless we are really sure
> it's fine.)
OK, but if this patch is acceptable, then there is no more places in the
tree that define the FASTCALL macro, other than the empty default in
include/linux/linkage.h. So I think a second step would be to start to
get rid of FASTCALL callers elsewhere in the tree...thoughts?
Cheers,
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
