Pavel Emelyanov <[email protected]> writes: > [snip] > >>> We do have some current code in the network stack that fails miserably >>> when register_sysctl_table returns NULL, and there are explicit >>> checks for that. >> >> So that code would be failing today with CONFIG_SYSCTL=n? Unless the >> failing code is itself under #ifdef CONFIG_SYSCTL, in which case we don't >> need to change anything? > > Exactly! If the code checks for the return value it won't work > with CONFIG_SYSCTL=n, if it dies not - it may happily use the > sysctl stub and avoid extra ifdefs. > > But this difference looks clumsy :( So we remove the check as we clean up the code. Unless we happen to find something that can do something useful and reasonable is register_sysctl_xxxx fails. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/7] Start using sysctl paths in the core kernel code
- From: Pavel Emelyanov <[email protected]>
- [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Pavel Emelyanov <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Andrew Morton <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Pavel Emelyanov <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Andrew Morton <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Pavel Emelyanov <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Andrew Morton <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Andrew Morton <[email protected]>
- Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- From: Pavel Emelyanov <[email protected]>
- [PATCH 0/7] Start using sysctl paths in the core kernel code
- Prev by Date: [PATCH] Allow to disable CONFIG_SCSI_WAIT_SCAN=m in menuconfig.
- Next by Date: Re: [PATCH] fix x86-32 early fixmap initialization.
- Previous by thread: Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
- Next by thread: [PATCH 2/7][QUOTA] Use sysctl paths to register tables
- Index(es):
 |