From: Julia Lawall <[email protected]>
Date: Sun, 2 Dec 2007 21:05:24 +0100 (CET)
> From: Julia Lawall <[email protected]>
>
> There should be an of_node_put when breaking out of a loop that iterates
> using for_each_node_by_type.
>
> This was detected and fixed using the following semantic patch.
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> identifier d;
> type T;
> expression e;
> iterator for_each_node_by_type;
> @@
>
> T *d;
> ...
> for_each_node_by_type(d,...)
> {... when != of_node_put(d)
> when != e = d
> (
> return d;
> |
> + of_node_put(d);
> ? return ...;
> )
> ...}
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
Applied, but I had to fixup the trailing whitespace on this line:
> - if (!err)
> + if (!err) {
As indicated by GIT:
Adds trailing whitespace.
diff:9: if (!err) {
warning: 1 line adds whitespace errors.
Please correct these kinds of errors before submitting in
the future, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
