Re: HMAC broken on s390

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Dec 04 2007, Herbert Xu wrote:
> On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote:
> > Hi Herbert,
> > 
> > commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac
> > on s390 du to the usage of sg_chain():
> > 
> > static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents,
> >                             struct scatterlist *sgl)
> > {
> > #ifndef ARCH_HAS_SG_CHAIN
> >         BUG();
> > #endif
> > 
> > ARCH_HAS_SG_CHAIN is false for s390 (and also for some other arch's).
> > 
> > What should we do with this?
> 
> Looks like we took a step backwards because the chaining I had
> before worked on all architectures :)
> 
> I suppose either we'll have to do our own chaining again or implement
> it for all architectures.  I'll look into this.

You should continue to do your own chaining if it's a requirement for
the driver/layer to function, until we get rid of ARCH_HAS_SG_CHAIN.
That'll happen when all archs are converted.

So don't rely on scatterlist helping you with chaining just yet, sorry.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/