Re: [PATCH] isapnp driver semaphore to mutex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Daniel Walker <[email protected]> wrote:

> On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
> > * Daniel Walker <[email protected]> wrote:
> > 
> > > Changed the isapnp semaphore to a mutex.
> > 
> > cool - i'll give it a whirl.
> > 
> > small immaterial nit:
> > 
> > > Signed-Off-By: Daniel Walker <[email protected]>
> > 
> > it's Signed-off-by (note the capitalization). Having this consistent 
> > makes scripting around patches a tiny bit easier.
> 
> Yeah, I know about it but sometimes still slips by..

it's worth automating these repetative bits. I use small templates when 
creating patches. Also, it's worth running patches through 
scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a 
big issue at all, i just mentioned it in case you get a taste for 
sending more sem2mutex patches :-) ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux