Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

Bartlomiej Zolnierkiewicz wrote:

[PATCH] ide-cd: remove dead post_transform_command()

post_transform_command() call in cdrom_newpc_intr() has no effect because
it is done after the request has already been fully completed (rq->bio and
rq->data are always NULL).  It was verified to be true regardless whether
INQUIRY command is using DMA or PIO to transfer data (by using modified
Tejun Heo's test-shortsg.c utility and adding a few printk()-s to ide-cd).

This was uncovered thanks to the "blk_end_request: full I/O completion
handler (take 3)" patch series from Kiyoshi Ueda.

Cc: [email protected]
Cc: [email protected]
Cc: Kiyoshi Ueda <[email protected]
Cc: Jun'ichi Nomura <[email protected]>
Cc: Tejun Heo <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>

Acked-by: Sergei Shtylyov <[email protected]>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 26/28] blk_end_request: changing ide-cd (take 3)
    • From: Kiyoshi Ueda <[email protected]>
  • Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)
    • From: Bartlomiej Zolnierkiewicz <[email protected]>

• Prev by Date: Re: [PATCH] Declare PNP option parsing functions as __init
• Next by Date: Re: [PATCH] isapnp driver semaphore to mutex
• Previous by thread: Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)
• Next by thread: Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]