[PATCH 5/5] net/bonding: Allow setting and querying xmit policy regardless of mode

For consistency with the behaviour of the arp_ip_target option,
let /sys/class/net/bond0/bonding/xmit_hash_policy accept and report
current policy even if the bonding mode in effect does not use it.

Signed-off-by: Ferenc Wagner <[email protected]>
---
 drivers/net/bonding/bond_sysfs.c |   21 +++------------------
 1 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 9de2c52..11b76b3 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -456,17 +456,11 @@ static ssize_t bonding_show_xmit_hash(struct device *d,
 				      struct device_attribute *attr,
 				      char *buf)
 {
-	int count = 0;
 	struct bonding *bond = to_bond(d);
 
-	if ((bond->params.mode == BOND_MODE_XOR) ||
-	    (bond->params.mode == BOND_MODE_8023AD)) {
-		count = sprintf(buf, "%s %d\n",
-			xmit_hashtype_tbl[bond->params.xmit_policy].modename,
-			bond->params.xmit_policy);
-	}
-
-	return count;
+	return sprintf(buf, "%s %d\n",
+		       xmit_hashtype_tbl[bond->params.xmit_policy].modename,
+		       bond->params.xmit_policy);
 }
 
 static ssize_t bonding_store_xmit_hash(struct device *d,
@@ -484,15 +478,6 @@ static ssize_t bonding_store_xmit_hash(struct device *d,
 		goto out;
 	}
 
-	if ((bond->params.mode != BOND_MODE_XOR) &&
-	    (bond->params.mode != BOND_MODE_8023AD)) {
-		printk(KERN_ERR DRV_NAME
-		       "%s: Transmit hash policy is irrelevant in this mode.\n",
-		       bond->dev->name);
-		ret = -EPERM;
-		goto out;
-	}
-
 	new_value = bond_parse_parm((char *)buf, xmit_hashtype_tbl);
 	if (new_value < 0)  {
 		printk(KERN_ERR DRV_NAME
-- 
1.4.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2/3] net/bonding: Return nothing for not applicable values
    • From: =?utf-8?q?Ferenc_W=C3=A1gner?= <[email protected]>
  • [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.
    • From: =?utf-8?q?Ferenc_W=C3=A1gner?= <[email protected]>
  • Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.
    • From: Wagner Ferenc <[email protected]>
  • Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.
    • From: Randy Dunlap <[email protected]>
  • [PATCH 4/3] net/bonding: Adhere to coding style: break line after the if condition
    • From: =?utf-8?q?Ferenc_W=C3=A1gner?= <[email protected]>
  • Re: [PATCH 2/3] net/bonding: Return nothing for not applicable values
    • From: Jay Vosburgh <[email protected]>

• Prev by Date: [PATCH 4/5] net/bonding: Adhere to coding style: break line after the if condition
• Next by Date: [PATCH 3/3] x86_64: use __PAGE_KERNEL_EXEC in ioremap_64.c
• Previous by thread: [PATCH 4/5] net/bonding: Adhere to coding style: break line after the if condition
• Next by thread: [PATCH 3/3] net/bonding: Purely cosmetic: rename a local variable.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]