Kristen Carlson Accardi wrote:
Enclosure Management via LED
This patch implements Enclosure Management via the LED protocol as specified
in AHCI specification.
Signed-off-by: Kristen Carlson Accardi <[email protected]>
---
This revision makes the change to the comment requested by Mark Lord,
fixes some bugs in the bit shifting for writing the new led state,
and implements a show function so that led status can be read as
well as written.
Overall looks pretty good, from a technical review perspective.
Two worries:
1) exporting ata_scsi_find_dev(), and assuming a scsi device is
attached. the latter can be fixed by a !NULL check (and should be), but
its a bit of a layering violation since long term we want to make the
SCSI simulator optional for all ATA devices.
2) vaguely related to #1, I'm not so sure the attributes should be
implemented directly in ahci. if this __or something like it__ appears
on non-Intel hardware, the code should be somewhere more generic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
