Re: [PATCH] Avoid overflows in kernel/time.c

On Sat, 1 Dec 2007 13:20:47 +0000
Alan Cox <[email protected]> wrote:

> On Sat, 1 Dec 2007 01:33:33 +0100
> Adrian Bunk <[email protected]> wrote:
> 
> > On Thu, Nov 29, 2007 at 04:19:51PM -0800, H. Peter Anvin wrote:
> > > When the conversion factor between jiffies and milli- or microseconds
> > > is not a single multiply or divide, as for the case of HZ == 300, we
> > > currently do a multiply followed by a divide.  The intervening
> > > result, however, is subject to overflows, especially since the
> > > fraction is not simplified (for HZ == 300, we multiply by 300 and
> > > divide by 1000).
> > >...
> > >  kernel/Makefile     |    8 +++
> > >  kernel/time.c       |   29 +++++++++---
> > >  kernel/timeconst.bc |  123 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 152 insertions(+), 8 deletions(-)
> > >  create mode 100644 kernel/timeconst.bc
> > >...
> > 
> > I have read the hep text, but are the advantages of HZ == 300 really 
> > visible or was this more theoretical?
> 
> Its visibile for people doing PAL media processing and TV sync work.

Wake up Alan - NTSC for 300HZ, PAL is OK at 250HZ setting.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Avoid overflows in kernel/time.c
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH] Avoid overflows in kernel/time.c
    • From: Adrian Bunk <[email protected]>
  • Re: [PATCH] Avoid overflows in kernel/time.c
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: [PATCH] Avoid overflows in kernel/time.c
• Next by Date: Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality
• Previous by thread: Re: [PATCH] Avoid overflows in kernel/time.c
• Next by thread: Re: [PATCH] Avoid overflows in kernel/time.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]