On 01-12-07 00:52, Bjorn Helgaas wrote:
On Friday 30 November 2007 04:37:26 pm Rene Herman wrote:
On 30-11-07 18:04, Thomas Renninger wrote:
If I have not overseen something, it should be rather obvious that those
can all be declared __init...
---------------
Declare PNP option parsing functions as __init
There are three kind of parse functions provided by PNP acpi/bios:
- get current resources
- set resources
- get possible resources
The first two may be needed later at runtime.
The possible resource settings should never change dynamically.
And even if this would make any sense (I doubt it), the current implementation
only parses possible resource settings at early init time:
-> declare all the option parsing __init
Signed-off-by: Thomas Renninger <[email protected]>
Yes. Obviousness aside,
(0) pnpacpi_add_device is only caller of
...
I agree this is probably safe in the current implementation.
However, I think the current implementation is just broken because
we can't really handle hotplug of ACPI devices. Specifically, I think
the first TBD in acpi_bus_check_device() should be fleshed out so it
does something like pnpacpi_add_device().
So my dissenting opinion is that this patch would just get reverted
soon anyway when somebody finishes implementing ACPI hotplug, and
therefore it's not worth doing.
<shrug>
The PnPBIOS bits should still be fine at least I guess. And, it would seem
this is rather essential to Thomas' efforts of making this stuff dynamic in
the first place anyway. In these threads, Alan Cox (added to CC) earlier
commented that with required locking when things are quite _that_ dynamic a
different setup than the one currently on the table seems in order.
I don't know, but small steps may make sense giving that it seems dynamic
allocation is fairly wanted with the massive number of PnPACPI resources
people are reporting since the warning about overrunning them was added.
Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
