Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

[snip]

>> +					&namespaces, path, table);
> 
> Hey Eric,
> 
> the patches look nice.

Agree ;)

> The hand-forcing of the passed-in net_ns into a copy of current->nsproxy
> does make it seem like nsproxy may not be the best choice of what to
> pass in.  Doesn't only net_sysctl_root->lookup() look at the argument?
> 
> But I assume you don't want to be more general than sending in a
> nsproxy so as to dissuade abuse of this interface for needlessly complex
> sysctl interfaces?
> 
> (Well I expect that'll become clear once the the patches using this
> come out.)
> 
> Are you planning to use this infrastructure for the uts and ipc
> sysctls as well?

I have sent some patches concerning uts and ipc already.
I'd appreciate any feedback on it :)

> thanks,
> -serge

Thanks,
Pavel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/4] Sysctl namespace support
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 1/4] sysctl: Add register_sysctl_paths function
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 2/4] sysctl: Remember the ctl_table we passed to register_sysctl_paths
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 3/4] sysctl: Infrastructure for per namespace sysctls
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure
    • From: "Serge E. Hallyn" <[email protected]>

• Prev by Date: Re: Out of tree module using LSM
• Next by Date: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
• Previous by thread: Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure
• Next by thread: Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]