Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge

Christoph Hellwig wrote:

On Thu, Nov 29, 2007 at 04:00:31AM -0800, Roland McGrath wrote:

+#define R32(l,q)							\
+	case offsetof(struct user32, regs.l):				\
+		regs->q = value; break
+
+#define SEG32(rs)							\
+	case offsetof(struct user32, regs.rs):				\
+		return set_segment_reg(child,				\
+				       offsetof(struct user_regs_struct, rs), \
+				       value);				\
+		break

The code would be a lot more readable if you just opencoded this in the
caller instead of these obsfucated macros.

For better or worse, though, that is style of existing code. I personally found it easy to deal with when I went through the code recently.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH x86/mm 01/11] x86-32 thread_struct.debugreg
    • From: Roland McGrath <[email protected]>
  • [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge
    • From: Roland McGrath <[email protected]>
  • Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: Out of tree module using LSM
• Next by Date: Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init
• Previous by thread: Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge
• Next by thread: Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]