On Wed, 28 Nov 2007 09:28:56 +0000 Al Viro <[email protected]> wrote: > > Eh... m68k has 16bit alignment for unsigned long. > > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -343,7 +343,8 @@ struct sdio_device_id { > __u8 class; /* Standard interface or SDIO_ANY_ID */ > __u16 vendor; /* Vendor or SDIO_ANY_ID */ > __u16 device; /* Device ID or SDIO_ANY_ID */ > - kernel_ulong_t driver_data; /* Data private to the driver */ > + kernel_ulong_t driver_data /* Data private to the driver */ > + __attribute__((aligned(sizeof(kernel_ulong_t)))); > }; > > /* SSB core, see drivers/ssb/ */ Unfortunately, that just papers over the symptom and doesn't solve the underlying issue. If you cross-compile on/for an arch with byte alignment, then the issue is back. Or one that uses 4-byte alignment even for u16. Is there no directive we can stick in there that forces a reasonable alignment (e.g. alignment == sizeof(type)) independently of arch? Rgds Pierre
Attachment:
signature.asc
Description: PGP signature
- Follow-Ups:
- Re: m68k build failure
- From: Geert Uytterhoeven <[email protected]>
- Re: m68k build failure
- References:
- m68k build failure
- From: Andrew Morton <[email protected]>
- Re: m68k build failure
- From: Pierre Ossman <[email protected]>
- Re: m68k build failure
- From: Andrew Morton <[email protected]>
- Re: m68k build failure
- From: Al Viro <[email protected]>
- m68k build failure
- Prev by Date: [s390] networking related oops during boot on Hercules (was: build failure)
- Next by Date: Re: git guidance
- Previous by thread: Re: m68k build failure
- Next by thread: Re: m68k build failure
- Index(es):
 |