Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

I just did a very quick glance over the tree.  Some extremly highlevel
comments to start with before actually starting the source review:


 - why do you need your own libcrc?  lib/crc32.c has a crc32_le
 - libsa should go.  Much of it is just wrappers of kernel functions
   that should be used directly.  Other like that hash, even or state
   helpers might either be opencoded in the caller or made completely
   generic in lib/.  Probably the former but we'll have to see.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
    • From: Chris Leech <[email protected]>

• References:
  • [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
    • From: "Love, Robert W" <[email protected]>

• Prev by Date: Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()
• Next by Date: [PATCH, v2] get rid of NR_OPEN and introduce a sysctl_nr_open
• Previous by thread: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
• Next by thread: Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]