Robert Hancock wrote:
> We need to run any DMA command with result taskfile requested in ADMA mode
> when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
> corruption could potentially result if this happened. Also WARN_ON() if we try
> and send result taskfile commands while NCQ commands are still active, since the
> hardware doesn't allow this.
>
> Signed-off-by: Robert Hancock <[email protected]>
>
> @@ -1425,9 +1427,17 @@
> + /* We can't handle result taskfile with NCQ commands active, since
> + retrieving the taskfile switches us out of ADMA mode and would abort
> + existing commands. */
> + WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) &&
> + (qc->ap->qc_allocated & ~(1 << qc->tag)));
I owe an apology here. ap->qc_allocated & ~(1 << qc->tag) test isn't
correct. Sorry. qc deferring happens after qc is allocated so the
condition can trigger (although it should be rare) even when nothing is
going wrong, so I guess it should be WARN_ON((qc->flags &
ATA_QCFLAG_RESULT_TF) && link->sactive).
Sorry. :-)
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
