On Fri 23 Nov 2007 16:52, Arjan van de Ven pondered:
> On Fri, 23 Nov 2007 22:25:29 +0800
> "Bryan Wu" <[email protected]> wrote:
>
> > On Nov 23, 2007 6:19 PM, David Woodhouse <[email protected]> wrote:
> > >
> > > On Fri, 2007-11-23 at 18:14 +0800, Bryan Wu wrote:
> > > >
> > > > +#ifdef CONFIG_BF54x
> > > > /* Setup DMAC1 channel mux for NFC which shared with SDH
> > > > */ val = bfin_read_DMAC1_PERIMUX();
> > > > val &= 0xFFFE;
> > > > bfin_write_DMAC1_PERIMUX(val);
> > > > SSYNC();
> > > > -
> > > > +#endif
> > >
> > > You can't build a multiplatform kernel which runs on BF52x and
> > > BF54x?
> >
> > There are some hardware difference between BF52x and BF54x. We have
> > to do this.
> >
>
> well does it need to be an #ifdef, or can it be a runtime if() ?
It could be a runtime if() but we don't currently have the is_mach() all set
up properly today.
This is because on most systems that Blackfin ships on - memory is the
dominate cost of the system, and end users don't want to take the either the
storage (flash) hit of having code they don't use, or the run time (DRAM)
overhead. They are fine with compiling 2 kernels for two platforms if it
means things are cheaper. :)
That being said, we still need to go back, and add things properly - and just
let gcc optimise things away if it is not used - c code is more maintainable
than all the ifdefs we have today.
This is the goal - it will just take a little bit to get there.
-Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
