Re: [PATCH 9/9] Clean up open coded inode dirty checks

> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip)
> +{
> +	return (((ip->i_itemp == NULL) ||
> +		!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
> +		(ip->i_update_core == 0));
> +}

Can we please get rid of this useless STATIC_INLINE junk?  It's really
hurting my eyes.  As does to a lesser extent the verbose style of this
function.  This should be something like:

static inline int xfs_inode_clean(struct xfs_inode *ip)
{
	return (!ip->i_itemp ||
	        !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
	       !ip->i_update_core;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 9/9] Clean up open coded inode dirty checks
    • From: Jan Engelhardt <[email protected]>

• References:
  • [PATCH 9/9] Clean up open coded inode dirty checks
    • From: David Chinner <[email protected]>

• Prev by Date: Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()
• Next by Date: Re: [PATCH 9/9] Clean up open coded inode dirty checks
• Previous by thread: [PATCH 9/9] Clean up open coded inode dirty checks
• Next by thread: Re: [PATCH 9/9] Clean up open coded inode dirty checks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]