Re: [patch 1/1] selinux: do not clear f_op when removing entries

On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote:
> Do not clear f_op when removing entries since it isn't safe to do.

If this is still safe for selinux I'm fine with it.  It also gets rid
of one of them few remaining s_files users which is always good.

Btw, after this patch we should be able to kill all places that check
for a non-zero file->f_op because it should never be non-zero.  Of course
we'll need an actual audit first to make sure nothing has been slipping
through.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/4] proc: fix NULL ->i_fop oops
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH 1/4] proc: fix NULL ->i_fop oops
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH 1/4] proc: fix NULL ->i_fop oops
    • From: Stephen Smalley <[email protected]>
  • Re: [PATCH 1/4] proc: fix NULL ->i_fop oops
    • From: Christoph Hellwig <[email protected]>
  • [patch 1/1] selinux: do not clear f_op when removing entries
    • From: Stephen Smalley <[email protected]>

• Prev by Date: [patch 1/1] selinux: do not clear f_op when removing entries
• Next by Date: Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)
• Previous by thread: [patch 1/1] selinux: do not clear f_op when removing entries
• Next by thread: Re: [patch 1/1] selinux: do not clear f_op when removing entries
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]