Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return

> > @@ -104,7 +103,7 @@ ENTRY(ia32_sysenter_target)
> >  	pushfq
> >  	CFI_ADJUST_CFA_OFFSET 8
> >  	/*CFI_REL_OFFSET rflags,0*/
> > -	movl	$VSYSCALL32_SYSEXIT, %r10d
> > +	movl	8*3-THREAD_SIZE+threadinfo_sysenter_return(%rsp), %r10d
> 
> 8*3-THREAD_SIZE is not very intuitive.  Can you add a comment on the
> math?

When you are reading the whole stretch of code right there, and not just
the patch, it's fairly obvious that it matches the three pushes right there.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00/18] x86 vDSO revamp
    • From: Roland McGrath <[email protected]>
  • [PATCH 13/18] x86 vDSO: ia32 sysenter_return
    • From: Roland McGrath <[email protected]>
  • Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return
    • From: Zachary Amsden <[email protected]>

• Prev by Date: Re: [PATCH 15/18] x86 vDSO: consolidate vdso32
• Next by Date: Re: CONFIG_IRQBALANCE for 64-bit x86 ?
• Previous by thread: Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return
• Next by thread: [PATCH 14/18] x86 vDSO: ia32 vdso32-syscall build
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]