Re: [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation

[Gautham R Shenoy <ego@in.ibm.com>]

On Thu, Nov 15, 2007 at 05:05:20PM +0100, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > FYI, i've put these 3 patches into the scheduler git tree and it's 
> > looking very good so far. So unless Andrew or Linus objects to put 
> > this into v2.6.24, or there's serious questions during review, could 
> > we merge it this way?
> 
> i've got this trivial build fix for !SMP - otherwise it's still looking 
> good.
> 

Thanks for this. I had compile tested only for !CONFIG_HOTPLUG_CPU and
missed !CONFIG_SMP.

Regards
gautham.

> 	Ingo
> 
> ------------------>
> Subject: cpu hotplug: fix build on !CONFIG_SMP
> From: Ingo Molnar <mingo@elte.hu>
> 
> fix build on !CONFIG_SMP.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  include/linux/cpu.h |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> Index: linux/include/linux/cpu.h
> ===================================================================
> --- linux.orig/include/linux/cpu.h
> +++ linux/include/linux/cpu.h
> @@ -71,19 +71,25 @@ static inline void unregister_cpu_notifi
> 
>  int cpu_up(unsigned int cpu);
> 
> +extern void cpu_hotplug_init(void);
> +
>  #else
> 
>  static inline int register_cpu_notifier(struct notifier_block *nb)
>  {
>  	return 0;
>  }
> +
>  static inline void unregister_cpu_notifier(struct notifier_block *nb)
>  {
>  }
> 
> +static inline void cpu_hotplug_init(void)
> +{
> +}
> +
>  #endif /* CONFIG_SMP */
>  extern struct sysdev_class cpu_sysdev_class;
> -extern void cpu_hotplug_init(void);
>  extern void cpu_maps_update_begin(void);
>  extern void cpu_maps_update_done(void);
> 

-- 
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/