On Sun, Nov 18, 2007 at 11:03:47AM +0100, Geert Uytterhoeven wrote:
> checkpatch: Print filenames of patches instead of the very uninformative
> `Your patch'.
Well this isn't quite enough as we often use this thing checking its
stdin. Which leads to an even less useful '- has no obvious ...'. I
guess a hybrid would be an improvement.
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> This patch is not `checkpatch' clean :-)
> Although I shortened 2 lines, they're still longer than 80 characters...
Heh, yeah its a pig getting those RE's into 80 chars.
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1408,10 +1408,10 @@ sub process {
> }
> }
> if ($clean == 1 && $quiet == 0) {
> - print "Your patch has no obvious style problems and is ready for submission.\n"
> + print "$filename has no obvious style problems and is ready for submission.\n"
> }
> if ($clean == 0 && $quiet == 0) {
> - print "Your patch has style problems, please review. If any of these errors\n";
> + print "$filename has style problems, please review. If any of these errors\n";
> print "are false positives report them to the maintainer, see\n";
> print "CHECKPATCH in MAINTAINERS.\n";
> }
-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
