On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote: > - wrmsrl(MSR_CSTAR, ia32_cstar_target); > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target); Hmm, why do you add explicit casts? The compiler should convert that correctly on its own. > +static inline void wrmsrl(unsigned int msr, unsigned long long val) Hmm, long long is 64 bit on all x86, but why not use explicit u64 to show that? Bastian -- Captain's Log, star date 21:34.5... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 7/24] consolidate msr.h
- From: Steven Rostedt <[email protected]>
- Re: [PATCH 7/24] consolidate msr.h
- References:
- [PATCH 0/24] paravirt_ops for unified x86 - that's me again!
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 2/24] irqflags consolidation
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 3/24] consolidate spinlock.h
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 4/24] tlb functions consolidation
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 5/24] smp x86 consolidation
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 6/24] Add debugreg/load_rsp native hooks
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 7/24] consolidate msr.h
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 0/24] paravirt_ops for unified x86 - that's me again!
- Prev by Date: Re: 2.6.24-rc3-git1: Reported regressions from 2.6.23
- Next by Date: Re: High priority tasks break SMP balancer?
- Previous by thread: Re: [PATCH 24/24] make vsmp a paravirt client
- Next by thread: Re: [PATCH 7/24] consolidate msr.h
- Index(es):
 |