On Mon, 2007-11-19 at 09:03 +0100, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> There should be a pci_dev_put when breaking out of a loop that iterates
> over calls to pci_get_device and similar functions.
>
> In this case, the return under the #else case of #ifdef HACKED_PCI_SAVE
> should have a pci_dev_put, just as the return in the case where
> HACKED_PCI_SAVE is true does.
>
> This was fixed using the following semantic patch.
I think most of that code is no longer necessary (and the lack of
pci_dev_put() is mostly due to the fact that this code long predates the
existence of pci_dev_put :-)
I want to try out without that PCI save/restore code on a couple of old
machines see if we can just remove the whole thing.
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
