Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Herbert Xu wrote:
BTW, how does the VLAN TX acceleration work at all? It's using
skb->cb to carry the tags but then calls dev_queue_xmit.  Once
you do that packet schedulers can scribble all over skb->cb.

Also vlan_skb_recv should be moved out-of-line.  It's absolutely
humongous.  It'll generate tail-calls anyway so performance-wise
it's useless.


I have a number of VLAN cleanups queued and intend to do these
two changes on top.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux