Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Herbert Xu <[email protected]>
Subject: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
From: Patrick McHardy <[email protected]>
Date: Fri, 16 Nov 2007 15:46:26 +0100
Cc: Joonwoo Park <[email protected]>, [email protected], "'David Miller'" <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], "'Kok, Auke'" <[email protected]>
In-reply-to: <[email protected]>
References: <006601c82846$b0f99eb0$9c94fea9@jason> <[email protected]>
Sender: [email protected]
User-agent: Mozilla-Thunderbird 2.0.0.4 (X11/20070828)

Herbert Xu wrote:

BTW, how does the VLAN TX acceleration work at all? It's using
skb->cb to carry the tags but then calls dev_queue_xmit.  Once
you do that packet schedulers can scribble all over skb->cb.

Also vlan_skb_recv should be moved out-of-line.  It's absolutely
humongous.  It'll generate tail-calls anyway so performance-wise
it's useless.



I have a number of VLAN cleanups queued and intend to do these
two changes on top.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
  - From: "Joonwoo Park" <[email protected]>
- Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
  - From: Herbert Xu <[email protected]>

Prev by Date: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Next by Date: Re: [RFC 5/7] LTTng instrumentation mm
Previous by thread: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Next by thread: [PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]

Powered by Linux