Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

Hi Roman.
> > If user did NOT specify ARCH we should use the kernel configuration - which
> > your solution fail to do.
> 
> To make this easy I attached the patch which reverts the problematic 
> changes and then you only need this simple change to force the 64BIT value 
> for ARCH={i386,x86_64}, otherwise it's set by the user:

Just eyeballing your patch I made following observations:
1) make all*config, randconfig, defconfig is broken on 64-bit boxes
2) A pure code refactoring patch is reverted for no obvious reason
3) Behavioral changes are not documented:
   - 32-bit/64-bit can only be selected in config is you specify ARCH=x86
   - ARCH= takes precedence over kernel config for a configured kernel
4) The changelogs miss title on reverted patches

All points are trivial to fix so I do not say your approach is
bad - just that the supplied patch is not good enough.

I will fix it up tonight and test it.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>

• References:
  • [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    • From: Roman Zippel <[email protected]>

• Prev by Date: Re: 2.6.24-rc2-mm1
• Next by Date: Re: [BUG] Strange 1-second pauses during Resume-from-RAM
• Previous by thread: Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
• Next by thread: Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]