Re: [patch 16/19] x86 setup: handle boot loaders which set up the stack incorrectly

["H. Peter Anvin" <hpa@zytor.com>]

Greg KH wrote:
> -stable review patch.  If anyone has any objections, please let us know.
>
> ------------------
> From: H. Peter Anvin <hpa@zytor.com>
>
> patch 6b6815c6d5d1dc209701d1661a7a0e09a295db2f in mainline.
>
> Apparently some specific versions of LILO enter the kernel with a
> stack pointer that doesn't match the rest of the segments.  Make our
> best attempt at untangling the resulting mess.
>
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Just FYI:

It has been reported that while this patch fixes old LILO, and possibly 
some other boot loaders (unknown), it has also broken older versions of 
SYSLINUX: they still boot, but the command line is truncated (exactly 
how much depends on the BIOS, but typical values are around 130 bytes.)

This is definitely traceable to a bug in SYSLINUX that was already fixed 
in release 3.50 (the current version of SYSLINUX is 3.52).

I have chosen to leave the patch in mainline, rather than trying yet 
another recipe and hope it doesn't break on some other random 
combination of bootloaders, since:

a) SYSLINUX is generally easily updated, compared to other bootloaders;
b) The failure mode is less severe (it still boots.)

... however, you may choose to call differently.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/