Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode

Tejun Heo wrote:
> If so, can you please add that switching into register mode is okay as
> long as there's no other ADMA commands in flight and add
> WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)?

More accurately, link->sactive test can be substituted with
(ap->qc_allocated & ~(1 << qc->tag)).

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
  - From: Robert Hancock <[email protected]>

References:
- [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
  - From: Robert Hancock <[email protected]>
- Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
  - From: Tejun Heo <[email protected]>

Prev by Date: Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
Next by Date: Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench
Previous by thread: Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
Next by thread: Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]