Re: [PATCH] Hibernation: Fix lockdep report (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 2007-11-14 22:25:57, Rafael J. Wysocki wrote:
> [Andrew, please consider this as 2.6.24 material, thanks.]
> ---
> From: Johannes Berg <[email protected]>
> 
> Lockdep reports a circular locking dependency in the hibernate code
> because
>  - during system boot hibernate code (from an initcall) locks pm_mutex
>    and then a sysfs buffer mutex via name_to_dev_t
>  - during regular operation hibernate code locks pm_mutex under a
>    sysfs buffer mutex because it's called from sysfs methods.
> 
> The deadlock can never happen because during initcall invocation nothing
> can write to sysfs yet. This removes the lockdep report by marking the
> initcall locking as being in a different class.
> 
> Signed-off-by: Johannes Berg <[email protected]>
> Cc: Alan Stern <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Pavel Machek <[email protected]>

ACK...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux