On Wed, 14 Nov 2007, Roland Dreier wrote:
> Drop #include <linux/moduleparam.h> in files that also include #include
> <linux/module.h>. module.h includes moduleparam.h already.
Do we want to make this sort of source code change? I thought that
the consensus about the kernel was that we wanted to avoid relying of
implicit includes of <Y.h> by <X.h> -- in this case a better change
would actually seem to be to explicitly include moduleparam.h in files
using module parameters and then remove the include from module.h.
Someone else made a similar comment, so it seems reasonable to forget
about the patches.
I could easily make a patch to go the other way if there is an interest in
that. On the other hand, perhaps the concensus is to just leave things
as they are.
julia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
