Re: [PATCH] 2.6.24-rc2-mm1 - Build Fail - fs/bfs/inode.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton пишет:
On Wed, 14 Nov 2007 10:30:54 +0530 Kamalesh Babulal <[email protected]> wrote:

Hi Andrew,

The kernel build fails, with following error

fs/bfs/inode.c: In function ‘bfs_iget’:
fs/bfs/inode.c:37: error: ‘ino’ redeclared as different kind of symbol
fs/bfs/inode.c:35: error: previous definition of ‘ino’ was here
fs/bfs/inode.c:37: error: ‘inode’ undeclared (first use in this function)
fs/bfs/inode.c:37: error: (Each undeclared identifier is reported onlyonce
fs/bfs/inode.c:37: error: for each function it appears in.)
make[2]: *** [fs/bfs/inode.o] Error 1
make[1]: *** [fs/bfs] Error 2
make: *** [fs] Error 2

Signed-off-by: Kamalesh Babulal <[email protected]>
--
--- linux-2.6.24-rc2/fs/bfs/inode.c	2007-11-14 09:53:41.000000000 +0530
+++ linux-2.6.24-rc2/fs/bfs/~inode.c	2007-11-14 10:21:06.000000000 +0530
@@ -34,7 +34,6 @@ void dump_imap(const char *prefix, struc
struct inode *bfs_iget(struct super_block *sb, unsigned long ino)
 {
-	unsigned long ino = inode->i_ino;
 	struct bfs_inode *di;
 	struct inode *inode;
 	struct buffer_head *bh;


bah.  That's what happens when I apply patches and fix rejects after doing
all my compile-coverage testing.

Thanks.  I put your two fixes into the hot-fixes/ directory.

Andrew, I tested the BFS driver using the 2.6.24-rc2-mm1 kernel and I can confirm that the bugs I reported earlier are gone now.

Frankly, I was not expecting that my fixes would be applied on top of the "stop using iget() and read_inode()" patches, that is why I prepared my patch against the Linus tree. Thank you for your work in merging the modifications.

Dmitri

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux