Joe,
can you please CC the relevant maintainers on patches ?
On Tue, 13 Nov 2007, Joe Perches wrote:
> Remove defconfig ptr comparison to 0
>
> The memcpy from memory location 0 sure looks odd.
The memcpy from 0 is completely bogus.
I bet this should have been a memset(&header, 0, ....), which is not
necessary at all, when the return value of acpi_get_table_header()
would be evaluated.
/me wonders why this never exploded
tglx
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[email protected]>
>
> ---
>
> diff --git a/include/asm-x86/mach-es7000/mach_mpparse.h b/include/asm-x86/mach-es7000/mach_mpparse.h
> index 8aa1054..a1dd66f 100644
> --- a/include/asm-x86/mach-es7000/mach_mpparse.h
> +++ b/include/asm-x86/mach-es7000/mach_mpparse.h
> @@ -29,7 +29,7 @@ extern int mps_oem_check(struct mp_config_table *mpc, char *oem,
> static inline int es7000_check_dsdt(void)
> {
> struct acpi_table_header header;
> - memcpy(&header, 0, sizeof(struct acpi_table_header));
> + memcpy(&header, (void *)0, sizeof(struct acpi_table_header));
> acpi_get_table_header(ACPI_SIG_DSDT, 0, &header);
> if (!strncmp(header.oem_id, "UNISYS", 6))
> return 1;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
