Re: [patch 06/11] Text Edit Lock - Alternative code for x86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13 Nov 2007 at 13:46, Mathieu Desnoyers wrote:

> +void *text_poke_early(void *addr, const void *opcode, size_t len)
> +{
> +	memcpy(addr, opcode, len);
> +	text_sync(addr, len);
> +	return addr;
> +}

why do you need this function (vs. using text_poke throughout)?

> +#define kernel_wp_save(cr0)					\
> +	do {							\
> +		preempt_disable();				\
> +		cr0 = read_cr0();				\
> +		if (cpu_data(smp_processor_id()).wp_works_ok)	\

why do you need this test? if cr0.wp is ineffective, then it doesn't
matter whether it's on or off (in fact, at least the intel manual
says that 386s would not even let you change its value, they'll
silently ignore attempts of setting the wp bit).

> +			write_cr0(cr0 & ~X86_CR0_WP);		\
> +	} while (0)
> +
> +#define kernel_wp_restore(cr0)					\
> +	do {							\
> +		if (cpu_data(smp_processor_id()).wp_works_ok)	\

ditto...

> +			write_cr0(cr0);				\
> +		preempt_enable();				\
> +	} while (0)
>  
>  #endif /* _I386_ALTERNATIVE_H */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux