Re: [PATCH 1/3]: tty - fix network driver interactions with TCGET/SET calls

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

> net/irda/irnet/irnet_ppp.c: In function 'dev_irnet_ioctl':
> net/irda/irnet/irnet_ppp.c:738: warning: passing argument 2 of 'kernel_termios_to_user_termios_1' from incompatible pointer type
> net/irda/irnet/irnet_ppp.c:750: warning: passing argument 1 of 'user_termios_to_kernel_termios_1' from incompatible pointer type


net/irda isn't tty layer and is completely and totally hosed, has been
for ages. It fakes some tty bits to fool pppd and does it wrong.

The warnings are good - they are showing up real standing bugs.
Unfortunately as its not a real tty device they are not at all easy to
fix.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/