Re: [PATCH] module loader should not complain about unknown symbol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 13 November 2007 01:18:27 Jan Glauber wrote:
> If module A depends on module B and module B has not yet finished its
> init() the module loader may print a warning about an unknown symbol.
>
> This happens if module B is still in state MODULE_STATE_COMING,
> as module A runs into resolve_symbol() for a symbol from module B.
> resolve_symbol() return 0 in that case and causes the warning.

It also happens when a symbol is undefined, so this patch is a bad idea.

To do this properly you would change strong_try_module_get to return -EBUSY 
and -ENOENT, then change use_module(), then finally resolve_symbol(), then 
only print a warning when it returns something other than -EBUSY.

Better might be to put in a waitqueue and wake it up whenever a module is 
deleted or changes status.  Then use_module() can wait if 
strong_try_module_get() returns -EBUSY (up to 30 seconds, then print a 
warning and fail).

Hope that helps,
Rusty.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux