On Mon, 12 Nov 2007 15:34:40 +0000 David Howells <[email protected]> wrote:
> Andrew Morton <[email protected]> wrote:
>
> > > +# -*- makefile -*-
> >
> > what's that?
>
> Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its
> an Assembly file and not a makefile. This causes it to attempt to do
> automatic indentation on it. Do you want me to drop these annotation
> comments?
Doesn't worry me, but I'd suggest that such annotation be added to all such
files in a single separate patch.
otoh it'd be pretty dumb of emacs if there wasn't some way of telling it
the type of a file external from that file itself.
> > Note that because of unexport-asm-pageh.patch I turned the above hunk into
> >
> > ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
> > unifdef-y += a.out.h
> > endif
> >
> > which seems logical to me. We'll see how it tests out.
>
> Are you talking about in linux/Kbuild or in asm-generic/Kbuild.asm or both?
I forget which Kbuild file that was. But with the above change, both
include/asm-generic/Kbuild.asm and include/linux/Kbuild are using
unifdef-y.
> Anyway, it sounds reasonable.
>
> David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
