Re: [Lksctp-developers] [PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()

Jesper Juhl wrote:
> From: Jesper Juhl <[email protected]>
> 
> In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak 
> the storage allocated for 'abort' by returning from the function 
> without using or freeing it. This happens in case 
> "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to 
> the 'discard' label.
> Spotted by the Coverity checker.
> 
> The simple fix is to simply move the creation of the "abort chunk" 
> to after the possible jump to the 'discard' label. This way we don't   
> even have to allocate the memory at all in the problem case.
> 
> 
> Signed-off-by: Jesper Juhl <[email protected]>

Thanks.  I've applied this to my tree.

-vlad
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()
    • From: Jesper Juhl <[email protected]>

• Prev by Date: Re: PAGE_SIZE on 64bit and 32bit machines
• Next by Date: Re: build #338 failed for 2.6.24-rc2-g6e800af in linux/drivers/md/dm-mpath-hp-sw.c
• Previous by thread: [PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()
• Next by thread: [PATCH] Fix problem with size of allocation in libsas
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]