Re: [patch 1/6] x86: apicdef unification: some constants made unsigned

On Tue, 6 Nov 2007, Robert Richter wrote:

> -#define			GET_APIC_VERSION(x)	((x)&0xFF)
> -#define			GET_APIC_MAXLVT(x)	(((x)>>16)&0xFF)
> -#define			APIC_INTEGRATED(x)	((x)&0xF0)
> +#define			GET_APIC_VERSION(x)	((x)&0xFFu)
> +#define			GET_APIC_MAXLVT(x)	(((x)>>16)&0xFFu)
> +#define			APIC_INTEGRATED(x)	((x)&0xF0u)

 No point in doing this -- hexadecimal literals are unsigned by 
definition.  File a compiler bug if you see them interpreted otherwise.

  Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/6] x86: apicdef unification: some constants made unsigned
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [patch 1/6] x86: apicdef unification: some constants made unsigned
    • From: "Robert Richter" <[email protected]>

• References:
  • [patch 0/6] x86: apicdef.h unification
    • From: "Robert Richter" <[email protected]>
  • [patch 1/6] x86: apicdef unification: some constants made unsigned
    • From: "Robert Richter" <[email protected]>

• Prev by Date: Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]
• Next by Date: build #338 failed for 2.6.24-rc2-g6e800af in linux/drivers/md/dm-mpath-hp-sw.c
• Previous by thread: Re: [patch 1/6] x86: apicdef unification: some constants made unsigned
• Next by thread: Re: [patch 1/6] x86: apicdef unification: some constants made unsigned
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]